From cb255cf1f3163bc1308f9a08037fe11206a80296 Mon Sep 17 00:00:00 2001
From: Guillermo Pages <mail@guillermo.at>
Date: Fri, 7 Nov 2025 12:39:07 +0100
Subject: [PATCH] fix(api): remove fallback URLs, throw if env var not defined

Per user feedback and Chief Cole direction (Chief_Cole-20251107123442):
- Remove fallback URLs from all API clients
- Throw error if NEXT_PUBLIC_PYTHON_API_URL not defined
- Standardize on NEXT_PUBLIC_PYTHON_API_URL env var across all clients
- Production URL: https://api.playchoo.com (staging/prod share hostname)

Updated files:
- src/lib/api/courts.ts
- src/lib/api/materialisation.ts
- src/lib/api/slot-definitions.ts

All clients now fail fast with clear error if env var missing.
Build tested and passed.
---
 src/lib/api/courts.ts           | 6 +++++-
 src/lib/api/materialisation.ts  | 6 +++++-
 src/lib/api/slot-definitions.ts | 6 +++++-
 3 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/lib/api/courts.ts b/src/lib/api/courts.ts
index 399bfe7..fbe3fc7 100644
--- a/src/lib/api/courts.ts
+++ b/src/lib/api/courts.ts
@@ -14,7 +14,11 @@ import type {
   CourtError,
 } from '@/src/types/courts';
 
-const API_BASE_URL = process.env.NEXT_PUBLIC_API_BASE_URL || 'https://staging.api.playchoo.com';
+const API_BASE_URL = process.env.NEXT_PUBLIC_PYTHON_API_URL;
+
+if (!API_BASE_URL) {
+  throw new Error('NEXT_PUBLIC_PYTHON_API_URL environment variable is not defined');
+}
 
 type ApiResult<T> =
   | { success: true; data: T }
diff --git a/src/lib/api/materialisation.ts b/src/lib/api/materialisation.ts
index 74e7fea..7aae98c 100644
--- a/src/lib/api/materialisation.ts
+++ b/src/lib/api/materialisation.ts
@@ -12,7 +12,11 @@ import type {
   MaterialisationError,
 } from '@/src/types/materialisation';
 
-const API_BASE_URL = process.env.NEXT_PUBLIC_API_BASE_URL || 'https://staging.api.playchoo.com';
+const API_BASE_URL = process.env.NEXT_PUBLIC_PYTHON_API_URL;
+
+if (!API_BASE_URL) {
+  throw new Error('NEXT_PUBLIC_PYTHON_API_URL environment variable is not defined');
+}
 
 type ApiResult<T> =
   | { success: true; data: T }
diff --git a/src/lib/api/slot-definitions.ts b/src/lib/api/slot-definitions.ts
index f79b06a..ffe8138 100644
--- a/src/lib/api/slot-definitions.ts
+++ b/src/lib/api/slot-definitions.ts
@@ -4,7 +4,11 @@ import type {
   SlotDefinitionError,
 } from '@/src/types/slot-definitions';
 
-const API_BASE_URL = process.env.NEXT_PUBLIC_API_URL || 'https://api.playchoo.com';
+const API_BASE_URL = process.env.NEXT_PUBLIC_PYTHON_API_URL;
+
+if (!API_BASE_URL) {
+  throw new Error('NEXT_PUBLIC_PYTHON_API_URL environment variable is not defined');
+}
 
 type ApiResult<T> =
   | { success: true; data: T }